D12608: Akregator feed detector plugin: Do not crash Konqueror for an invalid URL

[Jonathan Marten]

marten created this revision.
marten added reviewers: Konqueror, Plasma.
marten requested review of this revision.

REVISION SUMMARY
  As described in the second case in https://bugs.kde.org/show_bug.cgi?id=393496, this Konqueror plugin will crash with an assert within KProtocolManager if it is given (passed on command line, typed in address bar, clicked link etc) an invalid URL or one with an unknown protocol.  This change fixes that by ensuring that the URL is valid before it is used.
  
  KELibs4Support and its includes/classes are still used by this plugin.  Porting them will follow in a separate review.

TEST PLAN
  Built konqueror with this change.  Observed no crash with the test cases as described in bug report, and correct operation of feed detection.

REPOSITORY
  R226 Konqueror

REVISION DETAIL
  https://phabricator.kde.org/D12608

AFFECTED FILES
  plugins/akregator/konqfeedicon.cpp

To: marten, #konqueror, #plasma
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20180430/c3db04fe/attachment.htm>