D12558: Don't filter out duplicated entries from places panel

Nathaniel Graham noreply at phabricator.kde.org
Sun Apr 29 14:22:54 BST 2018


ngraham accepted this revision.
ngraham added a comment.


  In D12558#255525 <https://phabricator.kde.org/D12558#255525>, @elvisangelaccio wrote:
  
  > This seems indeed an unrelated change from D9985 <https://phabricator.kde.org/D9985>. Since that commit doesn't explain why this code was needed, I think we can drop it.
  >
  > In D12558#254797 <https://phabricator.kde.org/D12558#254797>, @ngraham wrote:
  >
  > > However is this what we want, behaviorally? The code you're removing was designed to prevent showing duplicates.
  >
  >
  > Nope, that is handled by D9333 <https://phabricator.kde.org/D9333> and it should still work after this patch.
  
  
  Ah, thanks for clarifying! That explains why I couldn't reproduce the duplication when testing this patch, lol.

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D12558

To: arojas, #dolphin, ngraham, elvisangelaccio, renatoo
Cc: xyquadrat
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20180429/32a51f85/attachment.htm>


More information about the kfm-devel mailing list