D12446: Update window title after closing split view
Robert Jennings
noreply at phabricator.kde.org
Sun Apr 22 14:05:29 BST 2018
rjennings created this revision.
rjennings added a reviewer: Dolphin.
rjennings requested review of this revision.
REVISION SUMMARY
Posted this to bugs.kde.org. Just copy/pasting what I said there.
In dolphintabpage.cpp:
Through the connections set up in createViewContainer(), m_primaryViewContainer->setActive(true), at line 98, ends up triggering slotViewActivated().
Because m_primaryViewActive is true, oldActiveView is not set to the view needed in this particular situation. Both oldActiveView and newActiveView end up pointing to the same view and the connections are not set up.
Adding
m_primaryViewActive = false;
inside the if clause at line 93 seems to fix it?
REPOSITORY
R318 Dolphin
REVISION DETAIL
https://phabricator.kde.org/D12446
AFFECTED FILES
src/dolphintabpage.cpp
To: rjennings, #dolphin
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20180422/2830723e/attachment.htm>
More information about the kfm-devel
mailing list