D12337: Give the file dialogs a "Sort by" menu button on the toolbar

[Henrik Fehlauer]

rkflx added a comment.


  Hm, now you are getting quite off-topic. I thought we wanted to make sorting easier?
  
  In D12337#250147 <https://phabricator.kde.org/D12337#250147>, @ngraham wrote:
  
  > Nevertheless, this needs to be a broader discussion, and we can't address it as a part of the open/save dialog initiative. Because of this, we need to work around some of the limitations it imposes on us IMHO.
  
  
  On the contrary: Because of this, the sorting button should blend into the existing style, until the broader discussion reached an agreement. Adding workarounds everywhere where you push your personal opinion causes inconsistency and problems down the road when issues are fixed at their proper place.
  
  Your points are generic, you don't answer the question why it is suddenly the sorting button where all issues ("perfect" icon, text, button-like look etc.) have to be fixed immediately. You may not agree with some styling choices, but bringing the topic up in every review can get slightly tiring for everyone involved. Fix it in Breeze, instead, if you must.
  
  It's just a sorting button, and even macOS does not display text for it or has a perfect icon. To get what you want you even have to move all buttons to the side to create space, creating more problems…
  
  While you are discussing about the ideal button, people are objecting to the very idea to have this button. I'd rather go for the compromise here, than in the end to have no button at all. Personally I don't use sorting often and know of nobody who does, nevertheless I'd agree to the experiment of making it available more broadly. This does not mean sorting has to be the literal centerpiece of the dialog, though.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D12337

To: ngraham, #frameworks, #dolphin, #vdg, rkflx
Cc: andreaska, markg, broulik, anemeth, michaelh, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20180419/a41b0fc0/attachment.htm>