D12362: Fix inconsistent preview spacing and icon wiggly-ness when toggling previews in Icon mode

[Nathaniel Graham]

ngraham created this revision.
ngraham added a reviewer: Dolphin.
ngraham requested review of this revision.

REVISION SUMMARY
  Dolphin had some code to change the grid spacing when previews were toggled, in an attempt to optimize the view for 3:2 landscape photos. This was problematic for many reasons:
  
  - Conceptually, it was a bad idea to optimize the view for one specific use case. Previews are useful for more than just landscape photos, and this optimization would be inapplicable to any other set of files.
  - Folders entirely full of images commonly have some portrait-orientation images included too, so even if the goal were appropriate, it was a bad idea to optimize for only having landscape images.
  - For small sizes and medium icons (< 96px), the preview grid size was virtually identical to the non-preview grid size, so it has essentially no effect; all it did was make the icons wiggle strangely when previews were toggled.
  - For large large sizes (>= 96px), all it did was unnecessarily increase the horizontal grid spacing.
  
  Therefore, let's just remove this code.
  
  BUG: 393306
  FIXED-IN: 18.04.1

TEST PLAN
  - Go to Settings > View Modes > Icons and make the icon size and preview size identical for 64px
  - Toggle previews on and off
  - Change both sizes to 112x
  - Toggle previews on and off
  
  In both cases, the grid spacing does not change and the icons do not wiggle strangely. The only visual change is that previews turn on or off.
  
  Dolphin still works fine for viewing  3:2 landscape photos. 80px icons:
  
  192px icons:
  
  In fact, it's vastly //improved// for the >=96px use case since the grid spacing is no longer excessively wide

REPOSITORY
  R318 Dolphin

BRANCH
  fix-inconsistent-preview-grid-spacing (branched from Applications/18.04)

REVISION DETAIL
  https://phabricator.kde.org/D12362

AFFECTED FILES
  src/views/dolphinitemlistview.cpp

To: ngraham, #dolphin
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20180419/2952ddee/attachment.htm>