D12094: Modify "Find" button to be a toggle, tracking state across tabs & split views

[Scott Harvey]

sharvey added a comment.


  In D12094#246961 <https://phabricator.kde.org/D12094#246961>, @elvisangelaccio wrote:
  
  > I'd try to not add the second action to the `actionCollection()`
  
  
  Not adding the second action means we lose the ability to have the `Find...` button act as a toggle. I checked with David Faure, since he's the keeper of `KXmlGui`. He confirmed that two behaviors require two action-id entries. It seems we're up against a case of "that's just the way it works" and there isn't a way for me to cheat the system. I think we're stuck with a few limitations, at least until someone rewrites Dolphin in QML. (No, I'm not volunteering.)

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D12094

To: sharvey, ngraham, elvisangelaccio, #dolphin
Cc: anthonyfieroni, rkflx, #dolphin
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20180418/60498e55/attachment.htm>