D11204: Support NTFS hidden files

[Mark Gaiser]

markg added a comment.


  In D11204#247248 <https://phabricator.kde.org/D11204#247248>, @vonreth wrote:
  
  > The commit broke the build on mac.
  >
  >   11:43:10 /Users/packaging/Craft/BinaryFactory/macos-64-clang/build/kde/frameworks/tier3/kio/work/kio-5.45.0/src/ioslaves/file/file_unix.cpp:421:19: error: no matching function for call to 'getxattr'
  >    11:43:10     auto length = getxattr(filenameEncoded.data(), attrName, nullptr, 0);
  >    11:43:10                   ^~~~~~~~
  >    11:43:10 /usr/include/sys/xattr.h:61:9: note: candidate function not viable: requires 6 arguments, but 4 were provided
  >    11:43:10 ssize_t getxattr(const char *path, const char *name, void *value, size_t size, u_int32_t position, int options);
  >    11:43:10         ^
  >    11:43:10 /Users/packaging/Craft/BinaryFactory/macos-64-clang/build/kde/frameworks/tier3/kio/work/kio-5.45.0/src/ioslaves/file/file_unix.cpp:427:14: error: no matching function for call to 'getxattr'
  >    11:43:10     length = getxattr(filenameEncoded.data(), attrName, strAttr, xattr_size);
  >    11:43:10              ^~~~~~~~
  >    11:43:10 /usr/include/sys/xattr.h:61:9: note: candidate function not viable: requires 6 arguments, but 4 were provided
  >    11:43:10 ssize_t getxattr(const char *path, const char *name, void *value, size_t size, u_int32_t position, int options);
  >    11:43:10         ^
  >    11:43:10 2 errors generated.
  
  
  Ha, apparently linux and mac implement the same principle (xattr) but with different arguments (same function names).
  Linux docs: http://man7.org/linux/man-pages/man2/getxattr.2.html
  Mac docs: https://developer.apple.com/legacy/library/documentation/Darwin/Reference/ManPages/man2/getxattr.2.html
  
  Note for the mac one, the link above is to their legacy stuff (found via google). I don't know if they have a "non-legacy" version or completely new alternative.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D11204

To: rominf, #dolphin, #frameworks, dfaure
Cc: vonreth, kossebau, dfaure, markg, elvisangelaccio, ltoscano, anthonyfieroni, broulik, #frameworks, #dolphin, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20180416/485b2164/attachment.htm>