D12094: Modify "Find" button to be a toggle, tracking state across tabs & split views

[Elvis Angelaccio]

elvisangelaccio added a comment.


  I get a crash when I try to open the control menu:
  
    Thread 1 (Thread 0x7f6621f67d80 (LWP 32219)):
    [KCrash Handler]
    #6  0x00007f661936d860 in raise () from /usr/lib/libc.so.6
    #7  0x00007f661936eec9 in abort () from /usr/lib/libc.so.6
    #8  0x00007f661a059354 in QMessageLogger::fatal(char const*, ...) const () from /usr/lib/libQt5Core.so.5
    #9  0x00007f661a058b35 in qt_assert(char const*, char const*, int) () from /usr/lib/libQt5Core.so.5
    #10 0x00007f6621accf24 in DolphinMainWindow::addActionToMenu (this=0x55d0a3606770, action=0x0, menu=0x55d0a37b8c90) at ../src/dolphinmainwindow.cpp:1500
    #11 0x00007f6621acbf92 in DolphinMainWindow::updateControlMenu (this=0x55d0a3606770) at ../src/dolphinmainwindow.cpp:858
    #12 0x00007f6621ad916b in QtPrivate::FunctorCall<QtPrivate::IndexesList<>, QtPrivate::List<>, void, void (DolphinMainWindow::*)()>::call(void (DolphinMainWindow::*)(), DolphinMainWindow*, void**) (f=(void (DolphinMainWindow::*)(DolphinMainWindow * const)) 0x7f6621acbe50 <DolphinMainWindow::updateControlMenu()>, o=0x55d0a3606770, arg=0x7ffcd947faf0) at /usr/include/qt/QtCore/qobjectdefs_impl.h:134
    #13 0x00007f6621ad90d3 in QtPrivate::FunctionPointer<void (DolphinMainWindow::*)()>::call<QtPrivate::List<>, void>(void (DolphinMainWindow::*)(), DolphinMainWindow*, void**) (f=(void (DolphinMainWindow::*)(DolphinMainWindow * const)) 0x7f6621acbe50 <DolphinMainWindow::updateControlMenu()>, o=0x55d0a3606770, arg=0x7ffcd947faf0) at /usr/include/qt/QtCore/qobjectdefs_impl.h:167
    #14 0x00007f6621ad8ff6 in QtPrivate::QSlotObject<void (DolphinMainWindow::*)(), QtPrivate::List<>, void>::impl(int, QtPrivate::QSlotObjectBase*, QObject*, void**, bool*) (which=1, this_=0x55d0a3b91690, r=0x55d0a3606770, a=0x7ffcd947faf0, ret=0x0) at /usr/include/qt/QtCore/qobjectdefs_impl.h:396
    #15 0x00007f661a28b8ef in QMetaObject::activate(QObject*, int, int, void**) () from /usr/lib/libQt5Core.so.5
    #16 0x00007f661b849720 in QMenu::popup(QPoint const&, QAction*) () from /usr/lib/libQt5Widgets.so.5
    #17 0x00007f661b84bc2f in QMenu::exec(QPoint const&, QAction*) () from /usr/lib/libQt5Widgets.so.5
  
  I also don't see the Find action in the toolbar when I start Dolphin. What's going on?

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D12094

To: sharvey, ngraham, elvisangelaccio, #dolphin
Cc: anthonyfieroni, rkflx, #dolphin
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20180415/54800a58/attachment.htm>