D12094: Modify "Find" button to be a toggle, tracking state across tabs & split views

[Nathaniel Graham]

ngraham added a comment.


  Behaviorally, I cannot find any flaws for new users/installations. The button toggles on click, and changes its state appropriately in all circumstances. The keyboard shortcut focuses the list, and the escape key closes it.
  
  However, I noticed a bug for existing installations: now the toolbar item list has two Find items in it, I think because you renamed the `edit_find` action to `toggle_find` in `dolphinui.rc`:
  F5803432: Two.png <https://phabricator.kde.org/F5803432>
  
  ...And the old one doesn't have the new toggle behavior. So existing users with the Find button in their toolbars won't actually get the feature.
  
  Is there a way you can not rename `edit_find`?

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D12094

To: sharvey, ngraham, elvisangelaccio, #dolphin
Cc: rkflx, #dolphin
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20180410/f51dd140/attachment.htm>