T8473: Dolphin 'Find' button behavior

[Scott Harvey]

sharvey created this task.
sharvey added a project: Dolphin.

TASK DESCRIPTION
  A feature request, from Bug 353227 <https://bugs.kde.org/show_bug.cgi?id=353227> - Make Dolphin's `Find...` button into a toggle, so it mimics the state of the search bar.
  
  Once I sorted through the `KToggleAction` stuff, it was pretty straightforward to implement this. But there are underlying design issues that make it not as simple as it appears.
  
  - Using the red `X` button to close the search bar will throw the toggled button out of sync. There's probably a way to solve that, though, except for...
  - There can be two view panes, but there's only one `Find` button. If it's a toggle, then it will **definitely** go out of sync when switching between panes.
  
  I'm at a crossroads. With just a single pane (and if we ignore the red `x`), it looks and works like the request asked - polished. But with multiple routes to throw things out of sync, I'm unsure how to proceed.
  
  Thoughts?

TASK DETAIL
  https://phabricator.kde.org/T8473

To: sharvey
Cc: ngraham, #dolphin, sharvey, spoorun, navarromorales, isidorov, firef, andrebarros, emmanuelp
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20180409/5c244dd6/attachment.htm>