D12039: Add more tab access functions

[Elvis Angelaccio]

elvisangelaccio requested changes to this revision.
elvisangelaccio added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> dolphintabwidget.h:43-44
>      /**
> +     * @return the next tab page. If the current active tab is the last tab,
> +     * it returns the first tab.
> +     */

We should also mention that the function will return `nullptr` if there is only one tab.

> dolphintabwidget.h:49-50
> +    /**
> +     * @return the previous tab page. If the current active tab is the first tab,
> +     * it returns the last tab.
> +     */

Same here.

> dolphintabwidget.h:52
> +     */
> +    DolphinTabPage* prevTabPage() const;
> +

We already have a `m_previousTab` variable that has a different meaning (previous = the tab that was previously active).

We should either rename this variable (e.g. `m_previousActiveTab`?), or find another name for this new function (but I cannot think of one...)

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D12039

To: ngraham, #dolphin, elvisangelaccio
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20180408/1ae21187/attachment.htm>