D11703: Select and scroll to the file for "Open path" operations

[Elvis Angelaccio]

elvisangelaccio requested changes to this revision.
elvisangelaccio added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> dolphinmainwindow.cpp:832-833
>          openNewTab(KIO::upUrl(item.url()));
> +        m_tabWidget->nextTabPage()->activeViewContainer()->view()->markUrlsAsSelected({item.url()});
> +        m_tabWidget->nextTabPage()->activeViewContainer()->view()->markUrlAsCurrent(item.url());
>          break;

Please remove, since this approach doesn't work.

> dolphintabwidget.h:46-52
> +    DolphinTabPage* nextTabPage() const;
> +
> +    /**
> +     * @return the previous tab page. If the current active tab is the first tab,
> +     * it returns the last tab.
> +     */
> +    DolphinTabPage* prevTabPage() const;

Let's add these two functions in another patch, since we don't need them here.

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D11703

To: ngraham, #dolphin, elvisangelaccio
Cc: elvisangelaccio, broulik
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20180407/66c7667d/attachment.htm>