D10702: Always use a job to delete files to avoid freezing process waiting on IO
Méven Car
noreply at phabricator.kde.org
Sat Apr 7 09:49:41 BST 2018
meven added a comment.
In term of comparison to the FileCopyJob for instance, the difference I can spot with the DeleteJob implementation, is that the FileCopyJobPrivate itselft instanciates a subJob in this case a DirectCopyJob that will do the work, using internally SimpleJobPrivate.
This internal SimpleJobPrivate is executed in a slave thread as I understand, allowing the UI thread to run during the file copy.
I guess the right way to fix that would be to refactor the delete operation in the same manner: using a SimpleJob to benefit from the slave thread, the Job API provides.
The downside is that it requires much more code editing.
Does it make sense ?
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D10702
To: meven, #frameworks, dfaure, ngraham, #dolphin, jtamate
Cc: jtamate, markg, ngraham, #frameworks, michaelh, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20180407/22daae63/attachment.htm>
More information about the kfm-devel
mailing list