D11972: [RenameDialog] Fix crash when renaming single items

Elvis Angelaccio noreply at phabricator.kde.org
Thu Apr 5 22:15:00 BST 2018


elvisangelaccio added a comment.


  In D11972#240794 <https://phabricator.kde.org/D11972#240794>, @cfeck wrote:
  
  > m_renamedItems is emitted in renamingFinished(). I haven't checked carefully, but is m_renamedItems correct for the single file rename?
  
  
  No, it's not. But it seems to be a pre-existing bug (already in 478f404b8a <https://phabricator.kde.org/R318:478f404b8abf924a0e3e21bbf1dd49aefbe47672>), as `renamingFinished()` was being emitted only in the multi-rename case.

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D11972

To: elvisangelaccio, cfeck, chinmoyr, #dolphin
Cc: #dolphin
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20180405/6668a723/attachment.htm>


More information about the kfm-devel mailing list