D11972: [RenameDialog] Fix crash when renaming single items

Elvis Angelaccio noreply at phabricator.kde.org
Thu Apr 5 21:38:40 BST 2018


elvisangelaccio created this revision.
Restricted Application added a subscriber: Dolphin.
elvisangelaccio requested review of this revision.

REVISION SUMMARY
  `m_spinBox` is initialized only when renaming multiple items.
  
  This commit restores the single-item rename logic which was wrongly
  removed by commit c5eb4e31161ccf422 <https://phabricator.kde.org/R318:c5eb4e31161ccf422a2f2492fe998c5c9817bea4>.

TEST PLAN
  Disable inline renaming and try to renaming single or multiple items (and also to undo the jobs).

REPOSITORY
  R318 Dolphin

BRANCH
  Applications/18.04

REVISION DETAIL
  https://phabricator.kde.org/D11972

AFFECTED FILES
  src/views/renamedialog.cpp

To: elvisangelaccio
Cc: #dolphin
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20180405/2fc28859/attachment.htm>


More information about the kfm-devel mailing list