D11894: Show folder previwes for items that have a Places Panel entry
Nathaniel Graham
noreply at phabricator.kde.org
Tue Apr 3 00:06:27 BST 2018
ngraham created this revision.
ngraham added a reviewer: Dolphin.
ngraham requested review of this revision.
REVISION SUMMARY
informationpanelcontent.cpp currently has an explicit check for whether or not a URL has a Places panel entry, and if it does, no folder preview is generated. It's not clear why this is done, but it was reported as a bug: https://bugs.kde.org/show_bug.cgi?id=392621. Removing the logic fixes the bug.
BUG: 392621
FIXED-IN: 18.08.0
TEST PLAN
Before:
After:
Detailed test procedure:
- Open the Information Panel
- Turn on previews
- Put some pictures in ~/Pictures
- Hover over it and see that the Information Panel shows a preview of its contents
- Add ~/Pictures to the Places panel
- Hover over it again and see that previews are no longer displayed
- Apply the patch and restart Dolphin
- Hover over it once more and see that there are now previews, yay!
REPOSITORY
R318 Dolphin
BRANCH
show-folder-previews-for-items-that-have-places-panel-entries (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D11894
AFFECTED FILES
src/panels/information/informationpanelcontent.cpp
To: ngraham, #dolphin
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20180402/6f696450/attachment.htm>
More information about the kfm-devel
mailing list