D11892: Don't override QDialogButtonBox::Yes text

Elvis Angelaccio noreply at phabricator.kde.org
Mon Apr 2 22:12:48 BST 2018


elvisangelaccio created this revision.
elvisangelaccio added a reviewer: Dolphin.
elvisangelaccio requested review of this revision.

REVISION SUMMARY
  We are asking the users whether they are sure they want to quit.
  
  But the "Quit" button can be ambiguous (am I quitting dolphing or just
  this dialog?). If we use a "Yes" button instead, that's clearly an
  answer to the question we just made.

TEST PLAN
  Close dolphin while multiple tabs are open.

REPOSITORY
  R318 Dolphin

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D11892

AFFECTED FILES
  src/dolphinmainwindow.cpp

To: elvisangelaccio, #dolphin
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20180402/6088da91/attachment.htm>


More information about the kfm-devel mailing list