D11871: [DolphinTabWidget] Rewrite tab widget close

[Anthony Fieroni]

anthonyfieroni created this revision.
anthonyfieroni added reviewers: Dolphin, elvisangelaccio.
anthonyfieroni requested review of this revision.

REVISION SUMMARY
  We introduce an issue in D5864 <https://phabricator.kde.org/D5864> by adding a QTimer, so it's never a good idea
  
  1. Add debug log in DolphinSearchBox::eventFilter FocusIn event
  2. Open search box
  3. Click add tab
  4. At log it'll see a loop of FocusIn events to 2 search boxes
  5. Click on item in Places, you have 50% possibility to change location of wrong tab

TEST PLAN
  Hold a QPointer of closed tab and behave like it's removed from tab widget if it's still not, removeTab delay it removing.

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D11871

AFFECTED FILES
  src/dolphinmainwindow.cpp
  src/dolphintabwidget.cpp
  src/dolphintabwidget.h
  src/search/dolphinsearchbox.cpp

To: anthonyfieroni, #dolphin, elvisangelaccio
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20180401/42e049a3/attachment.htm>