D11816: Split Image Size into Width/Height

[Nathaniel Graham]

ngraham added inline comments.

INLINE COMMENTS

> xyquadrat wrote in kfileitemmodel.cpp:1850
> TBH, I never heard of `Q_FALLTHROUGH()` before, so I had to look it up & found this: https://wiki.qt.io/Qt_Coding_Style#Switch_statements
> 
> Qt advises to not use this if another case follows immediately, but I can obviously still do this if this way is preferred here.

Hmm, what do you think @elvisangelaccio?

> elvisangelaccio wrote in kfileitemmodel.cpp:1850
> Correct, `Q_FALLTHROUGH` is not supposed to be used here.

Gotcha, thanks for the correction!

REPOSITORY
  R318 Dolphin

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D11816

To: xyquadrat, #dolphin, elvisangelaccio, ngraham
Cc: ngraham, elvisangelaccio
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20180401/f60783b8/attachment.htm>