D11816: Split Image Size into Width/Height

Elvis Angelaccio noreply at phabricator.kde.org
Sun Apr 1 09:58:57 BST 2018


elvisangelaccio accepted this revision.
elvisangelaccio added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> xyquadrat wrote in kfileitemmodel.cpp:1850
> TBH, I never heard of `Q_FALLTHROUGH()` before, so I had to look it up & found this: https://wiki.qt.io/Qt_Coding_Style#Switch_statements
> 
> Qt advises to not use this if another case follows immediately, but I can obviously still do this if this way is preferred here.

Correct, `Q_FALLTHROUGH` is not supposed to be used here.

REPOSITORY
  R318 Dolphin

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D11816

To: xyquadrat, #dolphin, elvisangelaccio, ngraham
Cc: ngraham, elvisangelaccio
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20180401/210c0757/attachment.htm>


More information about the kfm-devel mailing list