D7647: Two clicks on file/folder to rename

[funkybomber]

funkybomber added a comment.


  In https://phabricator.kde.org/D7647#148000, @ngraham wrote:
  
  > This works really well in my testing. I like it. Let's implement rename-with-long-press in another patch.
  
  
  Hello everyone, and thank you for your time and effort to get this bug fixed! :)
  
  I would like to raise some concerns regarding the "single-long-click to rename" approach:
  
  **1) **It might introduce ambiguity / usability issues in the following scenarios:
  
  - 1.1) When a user attempts to do a drag-n-drop and he/she simply is too slow to start moving the mouse. Having noticed the behaviour of novice users (my parents), sometimes they do take their time when they hold down the left click before they start moving the mouse around to drag-n-drop a file. With the "single-long-click to rename" approach, the file they wanted to move would just enter "rename mode".
  
  - 1.2) When a user attempts to do a drag-n-drop using a laptop trackpad. Basically the same issue, but it will affect a lot more people since practically everyone works more slowly/awkwardly with a trackpad.
  
  **2) **It can potentially introduce extra complexity.
  
  Who will determine after how long a rename action is triggered? There will obviously need to be a new slider (or a user input value "long-click-trigger-time" in microseconds) for the users to be able to tweak that. In comparison, the "two clicks to rename" approach doesn't really require ANY extra user input value since the "double-click-interval" value already exists.
  
  **3)** Might not be as efficient as the "two clicks to rename" approach under common multiple file rename scenarios.
  
  Let's consider a typical multiple file rename scenario. Let's say I have a folder with 20 files and I want to rename them all.
  
  Let's see how the "two clicks to rename" approach works:
  
  Steps:
  i) Press "Down" key to select --> The file we want to rename is now selected  (all good)
  ii) Click on the text of the file --> The filename is now editable  (all good)
  iii) Click on the appropriate place to place the cursor before we start typing  (all good)
  
  Let's see now how the "single-long-click to rename" approach works:
  
  Steps:
  i) Press "Down" key to select --> The file we want to rename is now selected  (all good)
  ii) Long click on the text of the file --> The filename is now editable  (long click feels like a waste of time here)
  iii) Click on the appropriate place to place the cursor before we start typing  (all good)

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D7647

To: akrutzler, #dolphin, #kde_applications, elvisangelaccio, emmanuelp, ngraham
Cc: funkybomber, sars, elvisangelaccio, ngraham, #konqueror
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20170925/5019d7c9/attachment.htm>