D7700: Show list of tags in PlacesView

[Mark Gaiser]

markg added inline comments.

INLINE COMMENTS

> placesitemmodel.cpp:91
>      m_bookmarkManager = KBookmarkManager::managerForExternalFile(file);
> +    m_dirLister = new KCoreDirLister();
>  

Set a parent (you can use "this" i think), then you don't have to delete it later on (the parent -> child structure will take care of it).
+ move it up to the constructor initializers.

Also, rename this variable. It's not a "dirLister" even though you use a K(Core)DirLister object. You listen for tags. Call it something like m_tagsLister or so.

> placesitemmodel.cpp:118
>      m_bookmarkedItems.clear();
> +    delete m_dirLister;
>  }

Remove this line if initializing m_dirLister in the constructor initialize section.

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D7700

To: nicolasfella, #dolphin, #kde_applications, alexeymin, ngraham
Cc: markg, anthonyfieroni, cfeck, elvisangelaccio, emmanuelp, ngraham, alexeymin, #dolphin, akrutzler, navarromorales, firef, andrebarros
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20170923/ec96c0c6/attachment.htm>