Review Request 121613: Fix bug 158264 - Terminal panel (konsole part) blocks the umount of removable media

[Alexander Zhigalin]

> On Фев. 18, 2017, 11:06 д.п., Alexander Zhigalin wrote:
> > Can you please port it to KF5?
> 
> Miklos Marton wrote:
>     Hello,
>     
>     Sure:
>     https://www.dropbox.com/s/w0cwsf0do9oomjn/dolphin_unmount_kf5.patch?dl=0
>     
>     Essentially the same patch rebased to the current dolphin ( d1b68db1a348f22eb8f6b6ffaae5097820385e83 ).
>     Two kind of changes were made:
>     - Changed the signal-slot connects from the connect(this, SLOT(foo), that SIGNAL(bar)) to connect(this, &This::foo, that, &That::bar)
>     - The slotTerminalDirectoryChanged url now contains the file:// prefix.
>     
>     Please review and merge because it is a pretty annoying issue, affects a plenty of users since 2008.
> 
> Miklos Marton wrote:
>     I have implemented the handling of the Solid::Ifaces::StorageAccess::teardownRequested signal, and it works fine.
>     
>     Updated patch can be found here:
>     https://www.dropbox.com/s/ixxhwk5x3uu4yqw/dolphin_unmount_kf5_handle_notifiation_unmount.patch?dl=0
> 
> Elvis Angelaccio wrote:
>     @Miklos Could you please upload your patch on Phabricator? 
>     
>     https://phabricator.kde.org/differential/diff/create/

@elvis https://phabricator.kde.org/D7847


- Alexander


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121613/#review102542
-----------------------------------------------------------


On Дек. 20, 2014, 8:39 п.п., Arjun AK wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121613/
> -----------------------------------------------------------
> 
> (Updated Дек. 20, 2014, 8:39 п.п.)
> 
> 
> Review request for Dolphin.
> 
> 
> Bugs: 158264
>     http://bugs.kde.org/show_bug.cgi?id=158264
> 
> 
> Repository: kde-baseapps
> 
> 
> Description
> -------
> 
> Unmounting will fail if you are currently inside the mount point with the terminal kept opened. Therfore before attempting to unmount, we need to change the directory on the terminal.
> 
> 
> Diffs
> -----
> 
>   dolphin/src/dolphinmainwindow.h 9d4c003 
>   dolphin/src/dolphinmainwindow.cpp 95b08af 
>   dolphin/src/panels/places/placesitemmodel.h 4a374e5 
>   dolphin/src/panels/places/placesitemmodel.cpp 6accdc8 
>   dolphin/src/panels/places/placespanel.h 16112e8 
>   dolphin/src/panels/places/placespanel.cpp 720e07c 
>   dolphin/src/panels/terminal/terminalpanel.h b65239b 
>   dolphin/src/panels/terminal/terminalpanel.cpp f827503 
> 
> 
> Diff: https://git.reviewboard.kde.org/r/121613/diff/1/
> 
> 
> Testing
> -------
> 
> Everything seems to work properly. Didn't find any view-terminal sync issues.
> 
> 
> Thanks,
> 
> Arjun AK
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20170917/07341d96/attachment.htm>