D7847: Fix bug 158264 - Terminal panel (konsole part) blocks the umount of removable media

[Miklos Marton]

martonmiklos marked an inline comment as done.
martonmiklos added inline comments.

INLINE COMMENTS

> zhigalin wrote in dolphinmainwindow.cpp:1011
> It really should be inside `else`?

Yes.

The purpose of this condition is basically delaying the call of proceedWithTearDown() when the terminal is visible until the terminal changed back to the home folder.

If the terminal was visible the proceedWithTearDown will be called after the terminal successfully cd-ed back to the home directory: in the DolphinMainWindow::slotTerminalDirectoryChanged(const QUrl& url) see line 253.

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D7847

To: martonmiklos, #dolphin
Cc: zhigalin, navarromorales, firef, andrebarros, emmanuelp
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20170916/28181380/attachment.htm>