D6281: Prevent folders from drag and dropping onto themselves in dolphin main view

[Emirald Mateli]

emateli added inline comments.

INLINE COMMENTS

> anthonyfieroni wrote in kfileitemmodel.h:76
> Yes, but it does nothing, you override it in declaration but definition is missing.

So, this is what I get when building without the override mark. Obviously it's just wa warning rather than an error, but I think it's best not to ignore it.

  In file included from ./src/kitemviews/kfileitemlistview.cpp:24:0:
  ./src/kitemviews/kfileitemmodel.h:76:10: warning: virtual QUrl KFileItemModel::directory() const can be marked override [-Wsuggest-override]
       QUrl directory() const;
            ^~~~~~~~~

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D6281

To: emateli, #dolphin, elvisangelaccio
Cc: elvisangelaccio, dfaure, anthonyfieroni, #konqueror, navarromorales, firef, andrebarros, emmanuelp
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20170914/e637b903/attachment.htm>