D7700: Show list of tags in PlacesView

[Emmanuel Pescosta]

emmanuelp added a comment.


  Thanks for the patch!
  
  I think that we should show only a limited number of tags with an additional `Show All` (or something like that) which opens `tags://`.

INLINE COMMENTS

> placesitemmodel.cpp:96
> +
> +    // if tags are supported load them before loading the bookmarks
> +    if (KProtocolInfo::isKnownProtocol(QStringLiteral("tags"))) {

Why?

> placesitemmodel.cpp:1214
> +        const KIO::UDSEntry& entry = *it;
> +        QString name = entry.stringValue( KIO::UDSEntry::UDS_NAME);
> +

Use the URL instead.

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D7700

To: nicolasfella, #dolphin, #kde_applications, alexeymin
Cc: emmanuelp, ngraham, alexeymin, #dolphin, navarromorales, firef, andrebarros
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20170911/be4428d8/attachment.htm>