D7690: Add "Open in New Window to Dolphin's places context menu

Nathaniel Graham noreply at phabricator.kde.org
Mon Sep 11 03:08:34 BST 2017


ngraham marked 2 inline comments as done.
ngraham added a comment.


  @emmanuelp Does this look commitable now?

INLINE COMMENTS

> emmanuelp wrote in placespanel.cpp:238
> Please use `PlacesItemModel::convertedUrl(m_model->data(index).value("url").toUrl())` instead

I was just copying code I found elsewhere in Dolphin to do this. I've made the requested change.

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D7690

To: ngraham, #dolphin, #kde_applications, dfaure, aacid, elvisangelaccio, emmanuelp, broulik
Cc: emmanuelp, broulik, sefaeyeoglu, #dolphin, navarromorales, firef, andrebarros
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20170911/7737345f/attachment.htm>


More information about the kfm-devel mailing list