D7655: Make sure we always have Shift+Del as shortcut

Elvis Angelaccio noreply at phabricator.kde.org
Thu Sep 7 21:27:40 BST 2017


elvisangelaccio planned changes to this revision.
elvisangelaccio added a comment.


  In https://phabricator.kde.org/D7655#143604, @emmanuelp wrote:
  
  > Hmm I don't think that we should add additional shortcuts to user-defined shortcuts. What if the user assigned `{Shift, Del}` to something different?
  >
  > Maybe:
  >
  > 1. If shortcuts of `move_to_trash` (A) is a proper subset of the shortcuts of `delete` (B) -> use the keys of B\A to select the actual behavior of the remove action (in the default configuration B\A is equal to `{Shift}`)
  > 2. Else show both the `move_to_trash`and the `delete` action instead of the remove action
  >
  >   But I think this is too complicated and error-prone ...
  >
  >   Would it be possible to add constraints to the shortcut settings dialog? Maybe that `delete` is always a user selectable modifier key + shortcuts of `move to trash`?
  
  
  This could be done in KShortcutsEditor, yes. It would be a good solution, I'll give it a shot...

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D7655

To: elvisangelaccio, #dolphin, emmanuelp
Cc: markg, #konqueror
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20170907/1b29c221/attachment.htm>


More information about the kfm-devel mailing list