D7519: Fix DolphinRemoveAction Shift toggling on Wayland

[Emmanuel Pescosta]

emmanuelp accepted this revision.
emmanuelp added a comment.
This revision is now accepted and ready to land.


  Some nitpicks, looks good otherwise!

INLINE COMMENTS

> dolphinremoveaction.cpp:56
> +        break;
> +    case QueryShiftState:
> +        if (QGuiApplication::keyboardModifiers() & Qt::ShiftModifier) {

I would perform the resolving before the switch (by updating `shiftState`) to avoid the duplicated state/modifiers<->action mapping and instead add an unreachable assertion to the `QueryShiftState` case, but this is a matter of taste.

> dolphinremoveaction.h:42
> +
> +    enum ShiftState {
> +        QueryShiftState,

`enum class` with `Unknown`, `Pressed`, `Released` maybe? ;)

REPOSITORY
  R318 Dolphin

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D7519

To: elvisangelaccio, #dolphin, emmanuelp
Cc: dfaure, #konqueror
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20170906/953197e2/attachment.htm>