D7571: Enable modifying root-owned files in Dolphin

[Emmanuel Pescosta]

emmanuelp added inline comments.

INLINE COMMENTS

> folderspanel.cpp:260
>  
> -            KIO::Job* job = KIO::moveAs(oldUrl, newUrl);
> +            KIO::Job* job = KIO::moveAs(oldUrl, newUrl, KIO::PrivilegeExecution);
>              KJobWidgets::setWindow(job, this);

Why is the privileged execution opt-in instead of opt-out?

A KIO user usually doesn't care how KIO handles the requested operations, because KIO claims to be resource and network transparent. Thus, if KIO is able to perform privileged operations when needed, it should do it by default unless explicitly forbidden by the client.

Additionally, opt-in requires you to patch all KIO users (incl. unknown 3rd-party users), whereas opt-out only requires patching in some special cases (if there is any?).

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D7571

To: chinmoyr, #dolphin, dfaure, emmanuelp
Cc: elvisangelaccio, #konqueror
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20170903/6a60e62b/attachment.htm>