D7539: Dolphin - Add autoplay feature for media files

Christoph Feck noreply at phabricator.kde.org
Sat Sep 2 00:57:42 BST 2017


cfeck added inline comments.

INLINE COMMENTS

> phononwidget.cpp:94
> +
> +        if(GeneralSettings::autoPlayMediaFiles()) { //If the this radiobutton is checked, then
> +                connect(m_autoplaytimer, SIGNAL(timeout()), this, SLOT(play()));

- if(cond) -> if (cond)
- There is no need to add comments for obvious code. In fact, those comments lower readability instead of increasing it.

> phononwidget.h:82
> +        
> +        QTimer* m_autoplaytimer;
>  

- "Type* var" -> "Type *var"
- lowercase -> camelCase

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D7539

To: pekkah, #dolphin, #kde_applications
Cc: cfeck, graesslin, anthonyfieroni, elvisangelaccio, #dolphin, pekkah, navarromorales, nicolasfella, firef, andrebarros, alexeymin, genaxxx, emmanuelp
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20170901/7a3189f8/attachment.htm>


More information about the kfm-devel mailing list