D6281: Prevent folders from drag and dropping onto themselves in dolphin main view

[Emirald Mateli]

emateli updated this revision to Diff 21411.
emateli added a comment.


  Fixed code being mistakenly surrounded by `HAVE_BALOO` directive and adjusted tests for the pure virtual method.
  
  > Well, I'm all for pure virtuals (and more const, BTW)
  
  Correct me If I'm wrong, but isn't returning const for objects that assigned by value kind of pointless since it's copied anyways?

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D6281?vs=21397&id=21411

REVISION DETAIL
  https://phabricator.kde.org/D6281

AFFECTED FILES
  src/kitemviews/kfileitemmodel.cpp
  src/kitemviews/kfileitemmodel.h
  src/kitemviews/kitemlistcontroller.cpp
  src/kitemviews/kitemlistcontroller.h
  src/kitemviews/kitemmodelbase.cpp
  src/kitemviews/kitemmodelbase.h
  src/panels/places/placesitemmodel.cpp
  src/panels/places/placesitemmodel.h
  src/tests/kitemlistselectionmanagertest.cpp

To: emateli, #dolphin, elvisangelaccio, ngraham, rkflx
Cc: rkflx, ngraham, elvisangelaccio, dfaure, anthonyfieroni, #konqueror, spoorun, navarromorales, firef, andrebarros, emmanuelp
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20171027/8b90cfd4/attachment.htm>