D7647: Two clicks on file/folder to rename

[Henrik Fehlauer]

rkflx accepted this revision.
rkflx added a comment.


  In https://phabricator.kde.org/D7647#160447, @akrutzler wrote:
  
  > Dragging items cancels twoClicksRenaming now.
  
  
  Thanks, works great.
  
  @elvisangelaccio Does your LGTM still hold?
  
  @akrutzler Assuming you do not have commit rights, what is your email address to be used when committing on your behalf? (identity.kde.org somehow does not know you, even if you are on Phabricator…)
  
  > Also:
  >  The detection, if the item selection has changed, takes place once after the timeout of twoClicksRenamingTimer now. Before this patch, this was done each time the selection changed.
  
  I like how you also changed from `index` to `url`. Together, this looks much cleaner now. Your test plan is much improved, too.

REVISION DETAIL
  https://phabricator.kde.org/D7647

To: akrutzler, #dolphin, #kde_applications, elvisangelaccio, emmanuelp, ngraham, markg, rkflx
Cc: rkflx, markg, funkybomber, sars, elvisangelaccio, ngraham
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20171026/9115c0a9/attachment.htm>