D7647: Two clicks on file/folder to rename

[Andreas Krutzler]

akrutzler added a comment.


  In https://phabricator.kde.org/D7647#160250, @rkflx wrote:
  
  > With your patch, explaining, understanding and executing the action is much harder:
  >
  > - Fast double click to open.
  > - Click to select.
  > - Second click to rename, but make sure to remember the fine print:
  >   - There is an additional timing constraints, which cannot be explained by "fast double click". Got to systemsettings, find the module and the setting, multiply by three, practice five times a week to get a feel for this interval.
  >   - Got it eventually? Great. Now make sure your are not clicking too fast, but also not too slow.
  >   - Coming back to the window and item is already selected? Well, is this case, for the feature to work you need to "select" again with a first click, without visual feedback though. We know this is inconsistent and for computers the first click does not turn sour like milk, but let's just pretend it does.
  >
  >     I hope you don't mind too much the style I wrote this in. My point is, that in the real world this is a much bigger problem than starting an accidental action (rename in this case), because there is so much else that executes on single click that users are already accustomed to it. The "double click to open" / "single click to select" really is just a feature to make selecting easier, not to require two clicks for every action.
  >
  >     But that are just my two cents. Apart from that your patch works fine and ultimately the maintainers of Dolphin should decide on something final, so this Diff can be closed eventually (it is dragging along for too long already).
  
  
  And again, I totally agree with you!
  
  In https://phabricator.kde.org/D7647#160254, @rkflx wrote:
  
  > Wow, I found another issue (independent from the patch above):
  >
  > - Click to select, make sure to release mouse button.
  > - After DCI, drag item.
  > - Renaming unintentionally starts, preventing the drop action to show its context menu.
  >
  >   Probably we should start renaming only on mouse up (if cursor is still above the item) and not already on mouse down? Or abort renaming when dragging mode is entered?
  
  
  Thanks! :) It seems to me that you just found a new cancellation. So if one starts to drag an item, renaming needs to be canceled too. I will have a look at it.

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D7647

To: akrutzler, #dolphin, #kde_applications, elvisangelaccio, emmanuelp, ngraham, markg, rkflx
Cc: rkflx, markg, funkybomber, sars, elvisangelaccio, ngraham
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20171026/1cdda96a/attachment.htm>