D7647: Two clicks on file/folder to rename

[Henrik Fehlauer]

rkflx added inline comments.

INLINE COMMENTS

> akrutzler wrote in dolphinview.cpp:818
> We want to cancle on focus lost. 
> We don't want to prevent twoClicksRenaming to start if clicking on an already selected item after dolphin got focus again.
> 
> This is called every time if dolphin loses focus.

> We don't want to prevent twoClicksRenaming to start if clicking on an already selected item after dolphin got focus again.

We are probably talking about the same thing, but that's not what this line does. After re-examining: This is about cancelling a pending rename after the second click on focus loss, but before the lineedit activated. So the reason is different, but you should keep it :)

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D7647

To: akrutzler, #dolphin, #kde_applications, elvisangelaccio, emmanuelp, ngraham, markg, rkflx
Cc: rkflx, markg, funkybomber, sars, elvisangelaccio, ngraham
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20171022/f0c7c762/attachment.htm>