D7647: Two clicks on file/folder to rename

[Andreas Krutzler]

akrutzler marked 3 inline comments as done.
akrutzler added a comment.


  In https://phabricator.kde.org/D7647#155604, @elvisangelaccio wrote:
  
  > In https://phabricator.kde.org/D7647#155581, @rkflx wrote:
  >
  > > > I likely wanted to just give focus back to Dolphin, rather than start a renaming operation.
  > >
  > > On the other hand, executing actions when giving focus is already happening today, e.g. activating Dolphin by clicking on a folder will enter this folder. Shouldn't we rather be consistent here?
  >
  >
  > Right, I didn't think about that. Ok, ignore my previous comment then :)

INLINE COMMENTS

> sars wrote in dolphinview.cpp:1166
> This aborts the rename only during the double-click delay timeout and not if we select the item, focus another window and then click the item again.

In https://phabricator.kde.org/D7647#155604, @elvisangelaccio wrote:

> In https://phabricator.kde.org/D7647#155581, @rkflx wrote:
>
> > > I likely wanted to just give focus back to Dolphin, rather than start a renaming operation.
> >
> > On the other hand, executing actions when giving focus is already happening today, e.g. activating Dolphin by clicking on a folder will enter this folder. Shouldn't we rather be consistent here?
>
>
> Right, I didn't think about that. Ok, ignore my previous comment then :)

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D7647

To: akrutzler, #dolphin, #kde_applications, elvisangelaccio, emmanuelp, ngraham, markg, rkflx
Cc: rkflx, markg, funkybomber, sars, elvisangelaccio, ngraham
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20171021/134988c8/attachment.htm>