D7440: Turn on Dolphin icon previews by default

Mark Gaiser noreply at phabricator.kde.org
Sat Oct 21 19:13:41 BST 2017


markg resigned from this revision.
markg added a comment.


  I have my doubts for this one. The same block of code is now duplicated 4 times.. 3x in Dolphin, 1x in KIO.
  Why not wait? Getting this in is not *that* important.. On the other hand i do get that waiting half a year (for applications 18.04) also seems excessively long which is why i understand the workaround.
  
  Anyhow, code wise the change is fine.
  I don't want to be the one holding this change back so i'm resigning as reviewer to not block it.

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D7440

To: ngraham, #dolphin, #kde_applications, #vdg, markg
Cc: cfeck, andreaska, emmanuelp, andreask, markg, broulik, anthonyfieroni, davidedmundson, ltoscano, dfaure, elvisangelaccio, #konqueror, spoorun, navarromorales, firef, ngraham, andrebarros
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20171021/0b658efa/attachment.htm>


More information about the kfm-devel mailing list