D7440: Turn on Dolphin icon previews by default

[Nathaniel Graham]

ngraham added a comment.


  @markg
  I'm not sure I agree that the current preview generation behavior is bad enough to hold this up.
  
  1. Thumbnailing only the files in view is I believe how macOS finder handles this, too. Maybe it's just me, but I don't find this behavior distracting at all, and after 20+ years of supporting Mac users professionally and in my personal life, I don't think I can recall a single person complaining about the thumbnailing behavior.
  2. Use cases where this could actually be annoying (folder with thousands of huge images) are very rare corner cases; let's not let those overwhelm the benefits for the general case! And you can always turn off previews on a per-directory basis anyway using the button in the toolbar.
  3. If performance could use improvement, I'm all for it, but can we do that in another patch?
  
  @ltoscano
  As an alternative, I could change this to use `KIO::PreviewJob::availablePlugins()`, which differs from the new API I've added only in that it will also enable the text previewer plugin (but maybe poor Kai could live with that for a few days. :) ). Then I could switch to `KIO::PreviewJob::defaultPlugins()` once KF5.40 is released. Does that sound reasonable?

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D7440

To: ngraham, #dolphin, #kde_applications, #vdg, markg
Cc: cfeck, andreaska, emmanuelp, andreask, markg, broulik, anthonyfieroni, davidedmundson, ltoscano, dfaure, elvisangelaccio, #konqueror, spoorun, navarromorales, firef, ngraham, andrebarros
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20171021/4247604f/attachment.htm>