D7647: Two clicks on file/folder to rename

[Mark Gaiser]

markg accepted this revision.
markg added a comment.


  In https://phabricator.kde.org/D7647#156787, @akrutzler wrote:
  
  > In https://phabricator.kde.org/D7647#156773, @markg wrote:
  >
  > > In https://phabricator.kde.org/D7647#156686, @ngraham wrote:
  > >
  > > > @elvisangelaccio and @markg, how's this looking now?
  > >
  > >
  > > I don't see the suggested changes so a +1 is a bit premature.
  >
  >
  > I set all comments to "Done" where I know they are done. There are still some left with no further comments from you guys, so they are done too?
  
  
  Then it's fine by me.
  You could still initialize the m_twoClicksRenamingTimer in the constructor like:
  m_twoClicksRenamingTimer(new QTimer(this)), but i'm fine either way.
  
  If you don't do it then that 0 initialize should be a nullptr: m_twoClicksRenamingTimer(nullptr).

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D7647

To: akrutzler, #dolphin, #kde_applications, elvisangelaccio, emmanuelp, ngraham, markg
Cc: rkflx, markg, funkybomber, sars, elvisangelaccio, ngraham
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20171021/2426bfc6/attachment.htm>