D6281: Prevent folders from drag and dropping onto themselves in dolphin main view

[Elvis Angelaccio]

elvisangelaccio added a comment.


  Interesting, I can't reproduce anymore the issues I was having...

INLINE COMMENTS

> kitemlistcontroller.cpp:1338
> +{
> +    foreach(QUrl url, urls) {
> +        if (url.matches(destUrl, QUrl::StripTrailingSlash)) {

`foreach(const QUrl& url, urls)`

even though we should probably use the C++11 for loop, since `foreach` will be eventually deprecated.

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D6281

To: emateli, #dolphin, elvisangelaccio, ngraham
Cc: ngraham, elvisangelaccio, dfaure, anthonyfieroni, #konqueror, spoorun, navarromorales, firef, andrebarros, emmanuelp
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20171021/3cc69358/attachment.htm>