D8347: KIO::PreviewJob::defaultPlugins() function

[Mark Gaiser]

markg requested changes to this revision.
markg added a comment.
This revision now requires changes to proceed.


  I'm a bit skeptical about this function...
  It in fact is all plugins minus (in this case) the text thumbnail with no way to configure it afterwards.
  That means a updates blacklist can only be distributed in a new kio release.
  
  That's not ideal but i don't know which way would be acceptable either.
  
  It could be a config file,
  It could be a environment variable as a comma separated list.
  
  Anyhow, -1 for the missing @since, but others might have other suggestions on how to get that blacklist filled.

INLINE COMMENTS

> previewjob.h:198
> +     * Returns a list of plugins that should be enabled by default, which is all plugins
> +     * Minus the plugins specified in an internal blacklist
> +     */

You miss an @since line.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D8347

To: ngraham, #frameworks, broulik, #dolphin, markg
Cc: markg, anthonyfieroni, elvisangelaccio, #frameworks
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20171018/891aee7b/attachment.htm>