D7847: Don't block unmounting when terminal panel's cwd is the mountpoint

Miklos Marton noreply at phabricator.kde.org
Thu Oct 12 18:54:37 BST 2017


martonmiklos marked 2 inline comments as done.
martonmiklos added inline comments.

INLINE COMMENTS

> elvisangelaccio wrote in terminalpanel.h:49
> I'd use `AddToHistory` and `SkipHistory`.
> Not sure about the name of the enum itself, maybe `HistoryPolicy` ?

Thanks for the review, I agree and I have updated the requested changes.

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D7847

To: martonmiklos, #dolphin, ngraham, elvisangelaccio
Cc: cfeck, ltoscano, ngraham, elvisangelaccio, emmanuelp, zhigalin, spoorun, navarromorales, firef, andrebarros
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20171012/ab3d5f0b/attachment.htm>


More information about the kfm-devel mailing list