D7847: Don't block unmounting when terminal panel's cwd is the mountpoint

[Elvis Angelaccio]

elvisangelaccio requested changes to this revision.
elvisangelaccio added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> terminalpanel.h:48
>  public:
> +    enum HistoryAddingOption {
> +        AddCommandToHistory,

Why `public`? This is only used in a private method.
Also, we are using `enum class` for new enums, so we should do it also here for consistency.

> terminalpanel.h:49
> +    enum HistoryAddingOption {
> +        AddCommandToHistory,
> +        DontAddCommandToHistory

I'd use `AddToHistory` and `SkipHistory`.
Not sure about the name of the enum itself, maybe `HistoryPolicy` ?

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D7847

To: martonmiklos, #dolphin, ngraham, elvisangelaccio
Cc: cfeck, ltoscano, ngraham, elvisangelaccio, emmanuelp, zhigalin, spoorun, navarromorales, firef, andrebarros
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20171011/68a18521/attachment.htm>