Review Request 129383: Add explicit choices for executables/scripts execution

[Elvis Angelaccio]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129383/#review103791
-----------------------------------------------------------



Sorry for the delay. With this patch the settings dialog becomes slightly bigger, but I guess that's okay since this is supposed to be a temporary solution. Looks good otherwise.


src/settings/general/behaviorsettingspage.cpp
Lines 156 (patched)
<https://git.reviewboard.kde.org/r/129383/#comment69026>

    Why `KConfig::IncludeGlobals`? (old code doesn't use it).


- Elvis Angelaccio


On Nov. 12, 2016, 12:03 a.m., Don Nguyen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129383/
> -----------------------------------------------------------
> 
> (Updated Nov. 12, 2016, 12:03 a.m.)
> 
> 
> Review request for Dolphin and KDE Usability.
> 
> 
> Bugs: 371837
>     https://bugs.kde.org/show_bug.cgi?id=371837
> 
> 
> Repository: dolphin
> 
> 
> Description
> -------
> 
> This is the patch for the suggestion proposed by me for bug 371837.
> 
> 
> Diffs
> -----
> 
>   src/settings/general/behaviorsettingspage.h 96eaf3d 
>   src/settings/general/behaviorsettingspage.cpp 6d1e8bb 
>   src/settings/general/confirmationssettingspage.h e702fe8 
>   src/settings/general/confirmationssettingspage.cpp 2419dc0 
> 
> 
> Diff: https://git.reviewboard.kde.org/r/129383/diff/2/
> 
> 
> Testing
> -------
> 
> Manual testing.  
> make test passed.
> 
> 
> File Attachments
> ----------------
> 
> Behavior Settings
>   https://git.reviewboard.kde.org/media/uploaded/files/2016/11/12/78938499-c709-4d95-a202-0da21cd34b57__general.png
> 
> 
> Thanks,
> 
> Don Nguyen
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20171004/5b6004e5/attachment.htm>