Review Request 130007: Dolphin: Display message in terminal panel if Konsole is not installed

[Elvis Angelaccio]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130007/#review103789
-----------------------------------------------------------



Sorry this took so long. You may want to re-upload to patch on Phabricator, since Reviewboard will be closed soon.


src/panels/terminal/terminalpanel.cpp
Lines 120 (patched)
<https://git.reviewboard.kde.org/r/130007/#comment69024>

    Please wrap the message in an `i18n()` call.



src/panels/terminal/terminalpanel.cpp
Lines 121 (patched)
<https://git.reviewboard.kde.org/r/130007/#comment69025>

    `TerminalPanel` already has a layout (`m_layout`), so this is wrong and causes a runtime warning. 
    
    Either just use `m_layout` or make `hbox` a child of `m_layout`.


- Elvis Angelaccio


On March 12, 2017, 9:50 a.m., Don Nguyen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/130007/
> -----------------------------------------------------------
> 
> (Updated March 12, 2017, 9:50 a.m.)
> 
> 
> Review request for Dolphin.
> 
> 
> Bugs: 371822
>     https://bugs.kde.org/show_bug.cgi?id=371822
> 
> 
> Repository: dolphin
> 
> 
> Description
> -------
> 
> This patch will show a QLabel with the text "KonsolePart not found.  Install Konsole and restart Dolphin to enable this feature." in place of where the terminal widget would be if Konsole is not installed.
> 
> 
> Diffs
> -----
> 
>   src/panels/terminal/terminalpanel.cpp e952f23 
> 
> 
> Diff: https://git.reviewboard.kde.org/r/130007/diff/2/
> 
> 
> Testing
> -------
> 
> Manual testing, see screenshot.
> 
> 
> File Attachments
> ----------------
> 
> screen
>   https://git.reviewboard.kde.org/media/uploaded/files/2017/03/12/bd1202ee-cfa9-4de9-812f-fb55d34474c3__konsolepanel.png
> KMessageWidget
>   https://git.reviewboard.kde.org/media/uploaded/files/2017/03/18/0b11630a-1452-4785-8d35-04f4c1aceaa0__Screenshot_20170318_171143.png
> 
> 
> Thanks,
> 
> Don Nguyen
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20171003/d8e8a10d/attachment.htm>