D8540: Add more whitespace to the status bar
Elvis Angelaccio
noreply at phabricator.kde.org
Sun Nov 5 09:20:34 GMT 2017
elvisangelaccio requested changes to this revision.
elvisangelaccio added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> dolphinstatusbar.cpp:120
>
> - m_spaceInfo->setFixedHeight(contentHeight);
> + m_spaceInfo->setFixedHeight(fontHeight);
> m_spaceInfo->setMaximumWidth(fontMetrics.averageCharWidth() * 25);
Now the space bar is actually smaller on Oxygen. I think we should use `zoomSliderHeight` here, instead.
> dolphinstatusbar.cpp:124
>
> - m_progressBar->setFixedHeight(contentHeight);
> + m_progressBar->setFixedHeight(fontHeight);
> m_progressBar->setMaximumWidth(fontMetrics.averageCharWidth() * 25);
and also here
REPOSITORY
R318 Dolphin
REVISION DETAIL
https://phabricator.kde.org/D8540
To: januz, #dolphin, #vdg, ngraham, elvisangelaccio
Cc: rkflx, elvisangelaccio, ngraham, abetts, jensreuterberg, spoorun, navarromorales, firef, andrebarros, skadinna, emmanuelp, aaronhoneycutt, mbohlender
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20171105/a04238d4/attachment.htm>
More information about the kfm-devel
mailing list