D8273: Change window title when searching
    Elvis Angelaccio 
    noreply at phabricator.kde.org
       
    Thu Nov 30 22:01:00 GMT 2017
    
    
  
elvisangelaccio added inline comments.
INLINE COMMENTS
> dolphinmainwindow.cpp:1006
> +        if(m_activeViewContainer->currentSearchText().isEmpty()){
> +            const auto emptySearch = i18n("Empty search");
> +            setWindowTitle(emptySearch);
Please use title capitalization ("Empty Search")
Btw the local variable is not needed, we could just do `setWindowTitle(i18n(...))`
REVISION DETAIL
  https://phabricator.kde.org/D8273
To: xyquadrat, #dolphin, ngraham, elvisangelaccio
Cc: anthonyfieroni, elvisangelaccio, rkflx, emmanuelp, ngraham, #dolphin, spoorun, navarromorales, isidorov, firef, andrebarros
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20171130/31f0da10/attachment.htm>
    
    
More information about the kfm-devel
mailing list