D8630: Created unit test for PlacesItemModel

Elvis Angelaccio noreply at phabricator.kde.org
Mon Nov 27 14:03:54 GMT 2017


elvisangelaccio added inline comments.

INLINE COMMENTS

> placesitemmodeltest.cpp:177
> +
> +    const QString fakeHw = QFINDTESTDATA("fakecomputer.xml");
> +    QVERIFY(!fakeHw.isEmpty());

Can you please move the xml file into a `data/` subfolder and use `QFINDTESTDATA("data/fakecomputer.xml")` here?

Other than that, looks good to me now.

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D8630

To: renatoo, ervin, elvisangelaccio, mwolff
Cc: mwolff, elvisangelaccio, ngraham, #dolphin
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20171127/388e13fb/attachment.htm>


More information about the kfm-devel mailing list