D8630: Created unit test for PlacesItemModel

[Elvis Angelaccio]

elvisangelaccio added a comment.


  I'm getting this failure when running the test:
  
    ********* Start testing of PlacesItemModelTest *********
    Config: Using QtTest library 5.10.0, Qt 5.10.0 (x86_64-little_endian-lp64 shared (dynamic) release build; by GCC 7.2.0)
    WARNING: PlacesItemModelTest::initTestCase() testdata fakecomputer.xml could not be located!
       Loc: [../src/tests/placesitemmodeltest.cpp(177)]
    FAIL!  : PlacesItemModelTest::initTestCase() '!fakeHw.isEmpty()' returned FALSE. ()
       Loc: [../src/tests/placesitemmodeltest.cpp(178)]
    PASS   : PlacesItemModelTest::cleanupTestCase()
    Totals: 1 passed, 1 failed, 0 skipped, 0 blacklisted, 0ms
  
  Am I missing something?

INLINE COMMENTS

> placesitemmodeltest.cpp:183
> +    const QString bookmarsFileName = bookmarksFile();
> +    if (QFile::exists(bookmarsFileName)) {
> +        // Ensure we'll have a clean bookmark file to start

QFileInfo::exists would be faster

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D8630

To: renatoo, ervin, elvisangelaccio, mwolff
Cc: mwolff, elvisangelaccio, ngraham, #dolphin
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20171127/fcfc3ddb/attachment.htm>