D8630: Created unit test for PlacesItemModel

[Milian Wolff]

mwolff added inline comments.

INLINE COMMENTS

> renatoo wrote in placesitemmodeltest.cpp:44
> This is based on KIO unit test: https://github.com/KDE/kio/blob/master/autotests/kfileplacesmodeltest.cpp#L34
> 
> Not sure the reason for that. But I can change it to use QDir as requested if you think that will not cause any problem.

leave it as is then, but I don't see any reason for this code

> renatoo wrote in placesitemmodeltest.cpp:151
> I tried all models signals, and none is fired. 
> The problem is on placesitemmodel.cpp:101, that loads the bookmark data while on idle and we must wait for that to finish before start any test.

ok, but we could still use `QTRY_COMPARE` then, no?

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D8630

To: renatoo, ervin, elvisangelaccio, mwolff
Cc: mwolff, elvisangelaccio, ngraham, #dolphin
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20171123/8ecc2796/attachment.htm>